refactor: drop dependency on Node modules #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
added
2. developing
This removes and usage of Node modules, as this library is intended for the browser not Node.JS Otherwise you always had to polyfill the node modules. Signed-off-by: Ferdinand Thiessen <[email protected]>
This is needed for Node `path` compatibility. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/drop-node
branch
from
6e1bf6f to
925eb3d
Compare
susnux
added
3. to review
Contributor
Author
|
/backport to stable3 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 24 24
Lines 694 694
Branches 189 189
=======================================
Hits 633 633
Misses 50 50
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes and usage of Node modules, as this library is intended for the browser not Node.JS
Otherwise you always had to polyfill the node modules.