-
Notifications
You must be signed in to change notification settings - Fork 911
fix(l10n): fix plural forms in source language #8272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
74fbb08 to
2b7a6c7
Compare
mgallien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we not modify behavior of the script handling the transifex update mechanism
see https://github.com/nextcloud/docker-ci/blob/master/translations-desktop/handleDesktopTranslations.sh#L66-L72
in addition the original version of the transifex sync script was this nextcloud/docker-ci@6c2884c |
|
created a new attempt at automatically updating the still, the plural forms of new strings need to be added by us to that file. AFAIK it's not that easy to change these in Transifex for the source language (besides, the source translation file doesn't get pulled from Transifex during that update) |
2b7a6c7 to
bd7a70d
Compare
Signed-off-by: Jyrki Gadinger <[email protected]>
bd7a70d to
bb47be6
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8272.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
We can't rely on the file system detection because Windows is reporting the underlying file system. Fixes: nextcloud#8272



enis used as the fallback/default language for when no specific translation is available.Newer strings that require a plural form would end up with the source text, which could show up as e.g.
"1 minute(s) ago"in the GUI.The translations file for
enused to be updated via the Transifex bot until February 2020.