Skip to content

Conversation

@nilsding
Copy link
Member

en is used as the fallback/default language for when no specific translation is available.

Newer strings that require a plural form would end up with the source text, which could show up as e.g. "1 minute(s) ago" in the GUI.

The translations file for en used to be updated via the Transifex bot until February 2020.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not modify behavior of the script handling the transifex update mechanism
see https://github.com/nextcloud/docker-ci/blob/master/translations-desktop/handleDesktopTranslations.sh#L66-L72

@mgallien
Copy link
Collaborator

should we not modify behavior of the script handling the transifex update mechanism see https://github.com/nextcloud/docker-ci/blob/master/translations-desktop/handleDesktopTranslations.sh#L66-L72

in addition the original version of the transifex sync script was this nextcloud/docker-ci@6c2884c
when it was changed client_en.ts stopped being updated
my best guess is that this change is the issue
nextcloud/docker-ci@a89bd22#diff-f9f49f14bdb368726492f713becb203c3cfdb46b509f9c9918a5c3c54b0f75edR44-R45

@nilsding
Copy link
Member Author

created a new attempt at automatically updating the client_en.ts file at nextcloud/docker-ci#770 that should be similar to what it used to be

still, the plural forms of new strings need to be added by us to that file. AFAIK it's not that easy to change these in Transifex for the source language (besides, the source translation file doesn't get pulled from Transifex during that update)

@nilsding nilsding force-pushed the l10n/update-en-source branch from 2b7a6c7 to bd7a70d Compare May 26, 2025 08:47
@nilsding nilsding changed the title fix(l10n): reimport source language from transifex, fix plural forms in source language fix(l10n): fix plural forms in source language May 26, 2025
@nilsding nilsding requested a review from mgallien May 26, 2025 08:48
@mgallien mgallien force-pushed the l10n/update-en-source branch from bd7a70d to bb47be6 Compare July 16, 2025 07:27
@mgallien mgallien requested a review from i2h3 as a code owner July 16, 2025 07:27
@mgallien mgallien merged commit a334ebc into master Jul 16, 2025
15 of 16 checks passed
@mgallien mgallien deleted the l10n/update-en-source branch July 16, 2025 07:28
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-8272.zip

SHA256 checksum: 5c41541cdab8e2b87e75fc4374465e52b1c7d3b31e5086a7339054d474cfc424

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

nextcloud-android-bot pushed a commit to nextmcloud/desktop that referenced this pull request Aug 11, 2025
We can't rely on the file system detection because Windows is reporting the underlying file system.

Fixes: nextcloud#8272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants