Conversation
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
nilsding
force-pushed
the
bugfix/noid/settings-dialog
branch
from
8e55857 to
a8e48ce
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9599.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Rello
approved these changes
Mar 12, 2026
…t in the stack The wrapping QWidget would just assume the biggest size of any previous widget and never get smaller. As we can just™ set the scroll view's widget to be the stackwidget it's unnecessary anyway Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Collaborator
|
/backport to stable-33.0 |
It was kinda empty and the widgets were created in the C++ code anyway. Also makes the left account navigation toolbar scrollable through a scrollbar :) Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
let it grow, there's a parent widget anyway small refactoring too: .ui now has a QVBoxLayout as its base instead of a QGridLayout Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
… style Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
the padding is different between QWidget and QML style Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
mgallien
force-pushed
the
bugfix/noid/settings-dialog
branch
from
a8e48ce to
893ace8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves a couple of issues from the rc2 prototype:
settingsdialog.uias it has become kinda useless now -- the layout was already defined within the C++ side