fix(asyncimageresponse): enhance check for received SVG response #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

mgallien merged 5 commits into master from bugfix/9685/appicon-request

Mar 26, 2026

+43 −34

Merged

refactor(asyncimageresponse): use QMimeDatabase for SVG check

SonarQubeCloud / SonarCloud Code Analysis failed Mar 26, 2026 in 38m 26s

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4 New Code Smells (required ≤ 0)

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Unmodified variable "reply" of type "class QNetworkReply *" should be const-qualified.

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0l0W1Ua7K9fovm3oX9&open=AZ0l0W1Ua7K9fovm3oX9&pullRequest=9697

Remove the redundant return type of this lambda.

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0l0W1Ua7K9fovm3oX7&open=AZ0l0W1Ua7K9fovm3oX7&pullRequest=9697

Remove the redundant return type of this lambda.

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0l0W1Ua7K9fovm3oX6&open=AZ0l0W1Ua7K9fovm3oX6&pullRequest=9697

Remove the redundant return type of this lambda.

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0l0W1Ua7K9fovm3oX8&open=AZ0l0W1Ua7K9fovm3oX8&pullRequest=9697