Feature: set log level via settings UI #1027
Conversation
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
Nice feature, thank you! |
R0Wi
force-pushed
the
feature#977
branch
2 times, most recently
from
7c68994 to
11fa9ed
Compare
|
@susnux thanks for your review and sorry for the delayed response. I applied all your suggestions and rebased on the current |
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Thank you for working on this :)
I found two things:
- Align the default logging level with the one server uses (WARN)
- Please validate the given value before setting the system config
Signed-off-by: Robin Windey <[email protected]>
* Reduce nesting in VUE * Check value in backend before writing * Set WARN as default log level * VUE exception handling with logging Signed-off-by: GitHub <[email protected]>
|
@susnux implemented all your requested changes. Thanks again for the nice feedback. Code would now be ready for final reveiw 😄 |
|
🎉 |
Resolves: #977
Setting the backend log level is now possible via settings UI. The radiogroup also represents the current loglevel, which is set on the server.
The position of this UI element can be discussed. Maybe it's also worth introducing a new settings button for this.