Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions apps/files/src/actions/deleteAction.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/foobar.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand Down Expand Up @@ -348,7 +348,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/foo.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand All @@ -357,7 +357,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/bar.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand Down Expand Up @@ -394,7 +394,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/foo.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand All @@ -403,7 +403,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/bar.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand All @@ -412,7 +412,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/baz.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand All @@ -421,7 +421,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/qux.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand All @@ -430,7 +430,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/quux.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand Down Expand Up @@ -482,7 +482,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/foo.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand All @@ -491,7 +491,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/bar.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand Down Expand Up @@ -529,7 +529,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/foobar.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand Down Expand Up @@ -569,7 +569,7 @@ describe('Delete action execute tests', () => {
source: 'https://cloud.domain.com/remote.php/dav/files/test/foo.txt',
owner: 'test',
mime: 'text/plain',
permissions: Permission.READ | Permission.UPDATE | Permission.DELETE,
permissions: Permission.READ | Permission.UPDATE | Permission.WRITE | Permission.DELETE,
root: '/files/test',
})

Expand Down
4 changes: 2 additions & 2 deletions apps/files/src/actions/openLocallyAction.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('Open locally action conditions tests', () => {
})

describe('Open locally action enabled tests', () => {
test('Enabled for file with UPDATE permission', () => {
test('Enabled for file with WRITE permission', () => {
const file = new File({
id: 1,
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
Expand Down Expand Up @@ -130,7 +130,7 @@ describe('Open locally action enabled tests', () => {
})).toBe(false)
})

test('Disabled without UPDATE permissions', () => {
test('Disabled without WRITE permissions', () => {
const file = new File({
id: 1,
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
Expand Down
2 changes: 1 addition & 1 deletion apps/files/src/utils/permissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function isSyncable(node: Node): boolean {
return false
}

if ((node.permissions & Permission.UPDATE) === 0) {
if ((node.permissions & Permission.WRITE) === 0) {
return false
}

Expand Down
171 changes: 79 additions & 92 deletions build/frontend-legacy/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/frontend-legacy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@nextcloud/capabilities": "^1.2.1",
"@nextcloud/dialogs": "^7.1.0",
"@nextcloud/event-bus": "^3.3.3",
"@nextcloud/files": "^4.0.0-beta.8",
"@nextcloud/files": "^4.0.0-beta.9",
"@nextcloud/initial-state": "^3.0.0",
"@nextcloud/l10n": "^3.4.1",
"@nextcloud/logger": "^3.0.3",
Expand Down
Loading
Loading