Skip to content

Conversation

@joshtrichards
Copy link
Member

Summary

  • Fully aligns IEncryptionModule interface and implementation function signatures
  • Modernizes the interface (and its implementation) by introducing strict typing
  • Drops redundant implementation docblocks (100% of essential API documentation now centralized in the interface)
  • Helpful docblocks are added to non-interface helper functions for clarity and maintainability

Should be fully backwards compatible.

P.S. $position was already a de facto string. Any type related changes indicated in this PR for that parameter merely make it match implementation (and drop some casting). And despite it's name, it's used for string concatenation (at least in the context relevant to this PR).

TODO

  • ...

Checklist

@joshtrichards joshtrichards added feature: encryption (server-side) technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 14, 2026
One is always an int but the other is a string and often more than than the raw position, but an id marker (e.g. `5end`). 

Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: encryption (server-side) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants