Skip to content

refactor(encryption): add strict type hints to IEncryptionModule #57551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshtrichards wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

refactor(encryption): add strict type hints to IEncryptionModule #57551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
56bb416
chore: add typing to IEncryptionModule
joshtrichards Jan 14, 2026
8765205
chore: add type hints throughout IEncryptionModule implementation
joshtrichards Jan 14, 2026
86a6c35
chore: correct $position typing in IEncryptionModule
joshtrichards Jan 14, 2026
319754d
chore: add exceptions to IEncryptionModule contract docs
joshtrichards Jan 14, 2026
82709d8
chore: add simple docblock to interface IEncryptionModule
joshtrichards Jan 14, 2026
c26f275
chore: drop duplicated API docblocks from Encryption implementation
joshtrichards Jan 14, 2026
ec97a0d
chore: add docblocks to non-interface helper/utility functions
joshtrichards Jan 14, 2026
fce802f
chore: document implementation specific throws
joshtrichards Jan 14, 2026
000b665
chore: drop implementation specific throws from interface
joshtrichards Jan 14, 2026
7fcf4f8
chore: Update psalm-baseline.xml
joshtrichards Jan 14, 2026
0ecc192
chore: fixup to make $uid nullable for now
joshtrichards Jan 15, 2026
5aaddf1
chore: permit nullable $uid in IEncryptionModule.php...
joshtrichards Jan 15, 2026
fddd5f4
refactor(encryption): Distinguish blockId from position
joshtrichards Jan 15, 2026
77fc7b3
chore: swap position for blockId in Encryption module implementation
joshtrichards Jan 15, 2026
f8b4813
refactor(encryption): differentiate blockId from $this->position
joshtrichards Jan 15, 2026
f204f75
test(encryption): fix for typing + make testUser1/testUser2 realistic
joshtrichards Jan 15, 2026
ccfc7ad
chore: fixup typo
joshtrichards Jan 15, 2026
bfaf55c
chore: add proper cast
joshtrichards Jan 15, 2026
fff8fc7
chore: add formerly misssing getOwner from EncryptionTest
joshtrichards Jan 16, 2026
df6b518
test: add missing stubs to EncryptionTest
joshtrichards Jan 16, 2026
a35de2b
test(encryption): add stub for needDetailedAccessList to UpdateTest
joshtrichards Jan 16, 2026
67f8e6d
chore: add stub for getLegacyCipher to EncryptionTest
joshtrichards Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading