enh: warn during table manager promotion/demotion#1434
Merged
juliusknorr merged 4 commits intomainfrom Jan 7, 2025
Merged
Conversation
enjeck
force-pushed
the
warn-table-manager
branch
from
8cf9e5c to
74f35ef
Compare
enjeck
changed the title
enjeck
force-pushed
the
warn-table-manager
branch
from
74f35ef to
78bbc66
Compare
This comment was marked as outdated.
This comment was marked as outdated.
juliusknorr
approved these changes
Dec 5, 2024
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks good and wording also fits from my perspective 👍
Contributor
Author
Not really. I can change to the 'warning' color then |
enjeck
force-pushed
the
warn-table-manager
branch
from
807390d to
d7785c5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@enjeck looks good! let's just right align the cancel button like in other dialogs and we're golden. |
enjeck
force-pushed
the
warn-table-manager
branch
from
d7785c5 to
a259596
Compare
enjeck
force-pushed
the
warn-table-manager
branch
from
19d16cb to
3cd40c7
Compare
Contributor
Author
|
Switched from NcModal to NcDialog. Something looks off about the alignment to me, but I can't place it 🤔 :
|
enjeck
force-pushed
the
warn-table-manager
branch
from
3cd40c7 to
b6bcc11
Compare
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
warn-table-manager
branch
from
b6bcc11 to
876a75d
Compare
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Contributor
Author
|
/backport to stable0.8 |
backportbot
bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.