Skip to content

enhancement: UI fixes for create/edit row dialogs#1621

Merged
blizzz merged 4 commits intomainfrom
create-row-ui-fix
Mar 20, 2025
Merged

enhancement: UI fixes for create/edit row dialogs#1621
blizzz merged 4 commits intomainfrom
create-row-ui-fix

Conversation

@enjeck
Copy link
Contributor

@enjeck enjeck commented Feb 19, 2025

  • Realign "expand" icon for rich text in the "create row" modal
  • Wrap column description text to avoid overflow

Before

Screenshot from 2025-02-17 13-29-03

After

Screenshot from 2025-02-17 13-32-17

  • Resizes "edit row" modal since it was too large

Before

Screenshot from 2025-02-17 13-40-14

After

Screenshot from 2025-02-17 13-39-50

@enjeck enjeck requested a review from blizzz as a code owner February 19, 2025 05:51
blizzz
blizzz previously requested changes Feb 19, 2025
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverts a change that was purposefully done recently

@blizzz
Copy link
Member

blizzz commented Feb 19, 2025

Adding @marcoambrosini for review. Maybe the size of the modals need a discussion. Or maybe expand/narrow buttons, maybe remembering users preference (in browser).

@juliusknorr juliusknorr added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Feb 27, 2025
@juliusknorr
Copy link
Member

Please remember to add labels

@marcoambrosini
Copy link
Member

We talked about this in our 1on1 with @enjeck, I think it's fine to keep size large for all these dialogs

@enjeck enjeck force-pushed the create-row-ui-fix branch from 531cad1 to 814f3a1 Compare March 4, 2025 05:47
@enjeck
Copy link
Contributor Author

enjeck commented Mar 4, 2025

Please remember to add labels

Add labels where? The dialogs themselves already have the name property that serve the same purpose, I believe.

enjeck added 3 commits March 6, 2025 08:21
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the create-row-ui-fix branch from c402dbb to 2388187 Compare March 6, 2025 08:21
@juliusknorr
Copy link
Member

Please remember to add labels
Add labels where? The dialogs themselves already have the name property that serve the same purpose, I believe.

Sorry that was meta feedback on the github pull request ;)

Screenshot 2025-03-06 at 09 41 18

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick on indentation, otherwise 👍

Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
@enjeck enjeck requested a review from blizzz March 7, 2025 04:23
@blizzz blizzz merged commit 00cfd5d into main Mar 20, 2025
51 of 52 checks passed
@blizzz blizzz deleted the create-row-ui-fix branch March 20, 2025 17:25
@enjeck
Copy link
Contributor Author

enjeck commented Apr 1, 2025

/backport to stable0.8

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 1, 2025
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working design Related to the design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants