enhancement: UI fixes for create/edit row dialogs#1621
Merged
Conversation
87dccc5 to
531cad1
Compare
blizzz
previously requested changes
Feb 19, 2025
Member
blizzz
left a comment
There was a problem hiding this comment.
reverts a change that was purposefully done recently
Member
|
Adding @marcoambrosini for review. Maybe the size of the modals need a discussion. Or maybe expand/narrow buttons, maybe remembering users preference (in browser). |
Member
|
Please remember to add labels |
Member
|
We talked about this in our 1on1 with @enjeck, I think it's fine to keep size large for all these dialogs |
531cad1 to
814f3a1
Compare
Contributor
Author
Add labels where? The dialogs themselves already have the |
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
c402dbb to
2388187
Compare
Member
juliusknorr
reviewed
Mar 6, 2025
src/shared/components/ncTable/partials/rowTypePartials/RowFormWrapper.vue
Outdated
Show resolved
Hide resolved
juliusknorr
approved these changes
Mar 6, 2025
Member
juliusknorr
left a comment
There was a problem hiding this comment.
Nitpick on indentation, otherwise 👍
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Contributor
Author
|
/backport to stable0.8 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before
After
Before
After