Fix broken table UI #902
Fix broken table UI #902
Conversation
silverkszlo
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
hweihwang
force-pushed
the
fix-broken-table-ui
branch
from
2e37c96 to
d495119
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: silver <[email protected]>
- Add min-height to empty paragraphs to prevent collapse in SVG - Simplify dimension calculations using getBoundingClientRect Signed-off-by: silver <[email protected]>
Wrap editorContainer ref in styled div to prevent Text app from removing the CSS class and sizing when injecting content Signed-off-by: silver <[email protected]>
Replace manual DOM traversal with Text app's exposed getHTML() method for cleaner, more maintainable content extraction Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
silverkszlo
force-pushed
the
fix-broken-table-ui
branch
from
d495119 to
78848e0
Compare
- Hide the "Insert table" button in the toolbar if getHTML() in Text is not available Signed-off-by: silver <[email protected]>
silverkszlo
force-pushed
the
fix-broken-table-ui
branch
from
78848e0 to
e252adc
Compare
Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
silverkszlo
force-pushed
the
fix-broken-table-ui
branch
from
4f190e9 to
89bebc9
Compare
Needs this PR in Text: nextcloud/text#8080
The table editor was not correctly displayed on a NC 29 instance, because the retrieval of the html from the Text App's createTable API was not exposing the html via TipTaps getHtml()
→ Replace manual DOM traversal with Text app's exposed getHtml() method for cleaner, more maintainable content extraction
The conversion from a table to an image of the table, which is then being added to a whiteboard, was incorrect. It rendered only the first three columns and rows and was cutting off the rest.
→ Add
min-heightto empty paragraphs in body cells (tdelements) to prevent them from collapsing.→ Simplify the dimension calculations using
getBoundingClientRect.→ Add a minimal default table with header and one body row to ensure the table editor recognizes it as a proper table with columns.
In some versions the text app replaces the ref="editorContainer" element, removing the editor-container class and its sizing styles, resulting in a tiny editor. The fix wraps the ref in a separate styled div to preserve the layout.