Conversation
c5644c1 to
fa8f5b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3190 +/- ##
==========================================
+ Coverage 85.32% 85.35% +0.03%
==========================================
Files 158 159 +1
Lines 46888 47018 +130
==========================================
+ Hits 40005 40131 +126
- Misses 6883 6887 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Okay. I have to admit we have one test case that failed due to timeout I think. see here. Or could you help me to confirm this also? |
Fixes an issue identified in #3190 -- this shows up as 00:00:01 elapsed, breaking the snapshot.
Fixes an issue identified in #3190 -- this shows up as 00:00:01 elapsed, breaking the snapshot.
fa8f5b1 to
dfabdec
Compare
|
@yuzibo do I have to do anything on my end to configure self-hosted runners? (Probably, right?) |
I think no? If zizmor job has been added to nextest's CI workflow as Trevor Gross suggests. And I am waiting for the result from the job :) I forgot to push the latest code to my branch. Once done, I need the token from your side to register the riscv64 runner. Please to read this link then Then we can agree on a time to pass the token which will be expired in one hour. |
|
hmm, test failed again. let me to check it again |
dfabdec to
713a496
Compare
| runs-on: ${{ matrix.os }} | ||
| # NOTE: self-hosted riscv64 runners are experimental and may be flaky. | ||
| # Do not block CI on failures from this platform for now at inital stages of support. | ||
| continue-on-error: ${{ contains(matrix.os, 'self-hosted') }} |
There was a problem hiding this comment.
I think we can keep it running for a while then to decide if enable it nor not
Thanks. I've read the documentation. What time of day works best for you? I can do 17:00-21:00 Pacific Sunday March 22 or Monday March 23 (00:00-04:00 Monday March 23/Tuesday March 24 in UTC). After that my next availability is the same time, Sunday March 29. |
All times sound good to me. So we can do it at 00:00-04:00 Monday March 23 in UTC. Is it okay for you? Or let's sync this on zulipchat IM again. |
This is one attempt to add self hosted riscv64 runner for CI job.