Skip to content

fix(nextclade): remove invalid qc scoreWeight fields#121

Merged
ivan-aksamentov merged 1 commit intomainfrom
fix/nextclade-remove-invalid-scoreweight
Mar 6, 2026
Merged

fix(nextclade): remove invalid qc scoreWeight fields#121
ivan-aksamentov merged 1 commit intomainfrom
fix/nextclade-remove-invalid-scoreweight

Conversation

@ivan-aksamentov
Copy link
Member

Remove scoreWeight from qc.missingData and qc.mixedSites in the Nextclade dataset config (source and committed output).

The scoreWeight property is not defined on QcRulesConfigMissingData or QcRulesConfigMixedSites in the pathogen.json schema and is silently ignored. It is valid on snpClusters, frameShifts, and stopCodons (those are left unchanged).

  • Remove qc.missingData.scoreWeight from source and committed output
  • Remove qc.mixedSites.scoreWeight from source and committed output

⚠️ The existing dataset in nextclade_data is already patched in nextstrain/nextclade_data#440, so no immediate resubmission is needed. But without this upstream fix, the invalid fields will reappear on the next dataset submission from this workflow.

ℹ️ See pathogen.json schema for the QcRulesConfigMissingData and QcRulesConfigMixedSites definitions.

  1. Related to: fix: update wnv dataset schema fields nextclade_data#440

@ivan-aksamentov ivan-aksamentov merged commit ed0772a into main Mar 6, 2026
4 checks passed
@ivan-aksamentov ivan-aksamentov deleted the fix/nextclade-remove-invalid-scoreweight branch March 6, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant