Skip to content

make it run for ibis#244

Merged
suzannejin merged 62 commits intodevfrom
dev-config
Mar 27, 2025
Merged

make it run for ibis#244
suzannejin merged 62 commits intodevfrom
dev-config

Conversation

@suzannejin
Copy link
Contributor

@suzannejin suzannejin commented Mar 25, 2025

  • add test profile for ibis data
  • add dev profile for development related stuff (eg. development container)
  • modify channel combinations to properly handle the output from preprocessing and run through stimulus
  • fix problem with not caching check_model module
  • modify tune to output optuna artifacts

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/deepmodeloptim branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@suzannejin suzannejin marked this pull request as ready for review March 26, 2025 14:42
Copy link
Contributor

@luisas luisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for fixing the merging conflicts :)

test_name:
- "test"
- "test_ibis"
- "test_ibis_with_preprocessing"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test data is a small subset of ibis right? or is it the full dataset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it only has one TF
anyway the heavy part which is the tuning - i set max_sample to be very small, so it basically just runs for a bit and stops - to be fast

@suzannejin suzannejin merged commit 7a8fc7a into dev Mar 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants