-
Notifications
You must be signed in to change notification settings - Fork 14
make it run for ibis #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
make it run for ibis #244
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
8119497
remove examples - they are outdated
luisas 9f3a7d3
Fix ungrouped schema for preprocessing
luisas e30e3fb
fix schema description to template
luisas 5568a54
Add tuning trials option
luisas 05e70e0
Add emitting versions to all stimulus modules
luisas 2608b8d
Collect all the versions
luisas 3d99c17
Validate and parse tune trials range
luisas becb5ff
Add custom module to update stimulus config to test different number …
luisas 0628135
add replicates for tuning
luisas 785dcc1
fix publish dir directives
luisas 8cbc55e
fix prefix for tune
luisas 8fd062f
fix lint
luisas dc7e61f
Add ci test for tune eval
luisas 5ecd7a0
fix lint
luisas 8ae79ef
fix lint
luisas 20df67e
fix lint
luisas a1e0fc9
Fix eval test
luisas a084f6f
add dev.config for stimulus development stage related params
suzannejin c2b1508
Add first version of predict module
luisas 0c3deee
update schema for predict csv data
luisas 2c144e3
add first draft of evaluation subworkflow
luisas 15daf8f
add first draft evaluation subworkflow
luisas c284360
update predict module
luisas f93e8d7
fix bug with params.container_dev
suzannejin ab3f607
add test_ibis conf
suzannejin bbf290f
modify tune to store optuna artifacts
suzannejin e89f920
add test_ibis to ci
suzannejin 59c8fed
use downsampled data for test_ibis
suzannejin 5979d62
lint
suzannejin f666c03
update split_csv subworkflow to run split csv on each data
suzannejin 0f2cde3
improve naming from ch_sub_config to ch_config_split
suzannejin 2e013a2
properly combine data and config in transform_csv subworkflow
suzannejin be7ae8d
update test_ibis_with_preprocessing.config
suzannejin ad90efa
Merge branch 'dev' into dev-config
bjlang 7bc8b49
combine channels properly for tune subworkflow
suzannejin feac397
Merge branch 'dev-config' of https://github.com/nf-core/deepmodelopti…
suzannejin 24ecc08
allow params.genome to use local files
04f4c94
fix error with ch_genome
4dab01f
prediction module and subworkflows functional
luisas 74c2fdd
add compare tensors module
luisas 23b0979
solve issue with not caching CHECK_MODEL
suzannejin b4edb5c
remove the empty element from check model out
suzannejin 388a680
fix bug in tuning input channel parsing
suzannejin 64553a1
add comment
suzannejin e9b0324
update test_ibis.config
suzannejin d7bc654
properly save all results from tune module
suzannejin d3e2b6c
logic for predictions comparison
luisas df06bf1
add concat logic for cosine score
luisas 706541d
fix merging conflicts
luisas 66c6fbf
fix linting
suzannejin 25fe7ba
[automated] Fix code linting
nf-core-bot 4a475ba
fix small bug
suzannejin 538982f
Merge branch 'dev-config' of https://github.com/nf-core/deepmodelopti…
suzannejin 3fba9bf
add concat csv for cosine similarity
luisas 0a4f34b
update
luisas 16f1add
combination in one final csv
luisas 15dfb0e
clean
luisas f6033a0
reduce trials for test config
luisas 1e9d8e1
Update ci.ym
suzannejin f520da2
merge and resolve conflict
suzannejin 3a32edd
fix bug
suzannejin 7fd5ffd
add n_trial to meta
suzannejin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| params { | ||
| config_profile_name = 'Development profile' | ||
| config_profile_description = 'Params needed during development' | ||
|
|
||
| // container | ||
| container_dev = "docker.io/mathysgrapotte/stimulus-py:dev" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Nextflow config file for running minimal tests | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Defines input files and everything required to run a fast and simple pipeline test. | ||
|
|
||
| Use as follows: | ||
| nextflow run main.nf -profile test_ibis,<docker/singularity> --outdir <OUTDIR> | ||
|
|
||
| ---------------------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| params { | ||
| config_profile_name = 'Test ibis profile' | ||
| config_profile_description = 'Minimal ibis test dataset to check pipeline functions' | ||
|
|
||
| // Input data | ||
| data = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ibis_SP140/SP140_shade.stimulus.csv' | ||
| data_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/data.yaml' | ||
| model = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ConvBasic_withEfficientKAN.py' | ||
| model_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ConvBasic_withEfficientKAN.yaml' | ||
|
|
||
| // output | ||
| save_data = true | ||
| } | ||
|
|
||
| // Limit resources so that this can run on GitHub Actions | ||
| process { | ||
| maxRetries = params.max_retries | ||
| errorStrategy = params.err_start | ||
|
|
||
| withLabel:process_low { | ||
| cpus = { 1 } | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 10.m * task.attempt } | ||
| } | ||
| withLabel:process_medium { | ||
| cpus = { 2 } | ||
| memory = { 6.GB * task.attempt } | ||
| time = { 30.m * task.attempt } | ||
| } | ||
| withLabel:process_high { | ||
| cpus = { 4 } | ||
| memory = { 8.GB * task.attempt } | ||
| time = { 1.h * task.attempt } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Nextflow config file for running minimal tests | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Defines input files and everything required to run a fast and simple pipeline test. | ||
|
|
||
| Use as follows: | ||
| nextflow run main.nf -profile test_ibis,<docker/singularity> --outdir <OUTDIR> | ||
|
|
||
| ---------------------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| params { | ||
| config_profile_name = 'Test ibis profile - with preprocessing' | ||
| config_profile_description = 'Minimal ibis test dataset (with preprocessing) to check pipeline functions' | ||
|
|
||
| // Input data | ||
| data = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ibis_SP140/SP140_ghts.peaks' | ||
| data_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/data.yaml' | ||
| model = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ConvBasic_withEfficientKAN.py' | ||
| model_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ConvBasic_withEfficientKAN.yaml' | ||
| preprocessing_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/ibis/ibis_SP140/preprocessing.yaml' | ||
| genome = 'GRCh38' | ||
| bed_peak_size = 40 | ||
|
|
||
| // output | ||
| save_data = true | ||
| } | ||
|
|
||
| // Limit resources so that this can run on GitHub Actions | ||
| process { | ||
| maxRetries = params.max_retries | ||
| errorStrategy = params.err_start | ||
|
|
||
| withLabel:process_low { | ||
| cpus = { 1 } | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 10.m * task.attempt } | ||
| } | ||
| withLabel:process_medium { | ||
| cpus = { 2 } | ||
| memory = { 6.GB * task.attempt } | ||
| time = { 30.m * task.attempt } | ||
| } | ||
| withLabel:process_high { | ||
| cpus = { 4 } | ||
| memory = { 8.GB * task.attempt } | ||
| time = { 1.h * task.attempt } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Nextflow config file for running minimal tests | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Defines input files and everything required to run a fast and simple pipeline test. | ||
|
|
||
| Use as follows: | ||
| nextflow run nf-core/rnaseq -profile test,<docker/singularity> --outdir <OUTDIR> | ||
|
|
||
| ---------------------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| params { | ||
| config_profile_name = 'Test profile' | ||
| config_profile_description = 'Minimal test dataset to check pipeline functions' | ||
|
|
||
| // Input data | ||
| data = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/titanic/titanic_stimulus.csv' | ||
| data_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/titanic/titanic.yaml' | ||
| model = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/titanic/titanic_model.py' | ||
| model_config = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/titanic/titanic_model.yaml' | ||
|
|
||
| // tune parameters | ||
| tune_trials_range = "2,4,2" | ||
| tune_replicates = 2 | ||
|
|
||
| // predict data | ||
| prediction_data = params.pipelines_testdata_base_path + 'deepmodeloptim/testdata/titanic/titanic_stimulus.csv' | ||
|
|
||
| // output | ||
| save_data = false | ||
| } | ||
|
|
||
| // Limit resources so that this can run on GitHub Actions | ||
| process { | ||
| maxRetries = params.max_retries | ||
| errorStrategy = params.err_start | ||
|
|
||
| withLabel:process_low { | ||
| cpus = { 1 } | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 10.m * task.attempt } | ||
| } | ||
| withLabel:process_medium { | ||
| cpus = { 2 } | ||
| memory = { 6.GB * task.attempt } | ||
| time = { 30.m * task.attempt } | ||
| } | ||
| withLabel:process_high { | ||
| cpus = { 4 } | ||
| memory = { 8.GB * task.attempt } | ||
| time = { 1.h * task.attempt } | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test data is a small subset of ibis right? or is it the full dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it only has one TF
anyway the heavy part which is the tuning - i set max_sample to be very small, so it basically just runs for a bit and stops - to be fast