Skip to content

Conversation

@eduard-watchmaker
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

process {
withName: PARABRICKS_FQ2BAMMETH {
cache = 'lenient' // This is set because in the module command the index files are touched so as to have bwameth not complain
ext.args = '--low-memory'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this in all the runs, just on the tests

]
}

// SAMTOOLS_INDEX after PICARD_MARKDUPLICATES - publish to deduplicated when deduplication runs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this since we publish the *markdup.sorted.bam and .bai

@eduard-watchmaker
Copy link
Contributor Author

@nf-core-bot fix linting

@eduard-watchmaker
Copy link
Contributor Author

@nf-core-bot fix linting

@eduard-watchmaker
Copy link
Contributor Author

The linting really is giving me a hard time lol

@eduard-watchmaker
Copy link
Contributor Author

Tests 2 for conda, singularity and docker show different snapshots for the 'latest' version vs the 25.04, unsure why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants