-
Notifications
You must be signed in to change notification settings - Fork 163
Add fq2bam to methylseq #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eduard-watchmaker
wants to merge
10
commits into
dev
Choose a base branch
from
add_fq2bam_methylseq
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5aa5646
Merge pull request #585 from nf-core/dev
sateeshperi 5d8caa6
first iteration
eduard-watchmaker 78385dd
fixed subworkflow channels
eduard-watchmaker 2379f7a
tryna publish fq2bam bam
eduard-watchmaker 2fac2b3
tryna publish fq2bam bam
eduard-watchmaker ba9af88
not exposing intervals and known sites
eduard-watchmaker 497a7ce
broadcast fix
eduard-watchmaker b6e8899
broadcast fix
eduard-watchmaker 11f3137
fix
eduard-watchmaker be23997
Merge branch 'dev' into add_fq2bam_methylseq
eduard-watchmaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| process { | ||
| withName: PARABRICKS_FQ2BAM { | ||
| cache = 'lenient' // This is set because in the module command the index files are touched so as to have bwameth not complain | ||
| publishDir = [ | ||
| path: { "${params.outdir}/${params.aligner}/alignments" }, | ||
| pattern: "*.bam", | ||
| mode: params.publish_dir_mode, | ||
| enabled: params.save_align_intermeds | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
|
|
||
| includeConfig "../modules/bwamem_align.config" | ||
| includeConfig "../modules/parabricks_fq2bam.config" | ||
| includeConfig "../modules/picard_addorreplacereadgroups.config" | ||
| includeConfig "../modules/picard_markduplicates.config" | ||
| includeConfig "../modules/samtools_stats.config" | ||
|
|
@@ -35,16 +37,4 @@ process { | |
| ] | ||
| ] | ||
| } | ||
|
|
||
| // SAMTOOLS_INDEX after PICARD_MARKDUPLICATES - publish to deduplicated when deduplication runs | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't need this since we publish the *markdup.sorted.bam and .bai |
||
| withName: 'NFCORE_METHYLSEQ:METHYLSEQ:FASTQ_ALIGN_DEDUP_BWAMEM:SAMTOOLS_INDEX' { | ||
| publishDir = [ | ||
| [ | ||
| path: { "${params.outdir}/${params.aligner}/deduplicated/" }, | ||
| mode: params.publish_dir_mode, | ||
| pattern: "*.bai", | ||
| enabled: !params.skip_deduplication | ||
| ] | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this in all the runs, just on the tests