Liftover to sniffles nf-core module#313
Closed
nourmahfel wants to merge 7 commits intonf-core:devfrom
nourmahfel:master
Closed
Liftover to sniffles nf-core module#313nourmahfel wants to merge 7 commits intonf-core:devfrom nourmahfel:master
nourmahfel wants to merge 7 commits intonf-core:devfrom
nourmahfel:master
Conversation
This PR is against the
|
nourmahfel
commented
Mar 26, 2025
Author
nourmahfel
left a comment
There was a problem hiding this comment.
Updated the sniffles module to nf-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Replaced the local implementation of Sniffles with the standard nf-core/sniffles module to improve modularity and maintain consistency with nf-core best practices. Updated the subworkflow (structural_variant_calling.nf) to call the new module and commented out the local sniffles.nf process.
nextflow run . -profile test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.