Skip to content

Conversation

@nkongenelly
Copy link
Contributor

@nkongenelly nkongenelly commented Nov 24, 2025

This code allows subsampling to work with relative numbers too as the initial implementation limited it to absolute number of reads (#50).
seqtk_sample module itself allows passing fractions as the sample_size thus only our schema has been updated here to allow both integers and floats

Fixes #60

Co-authored-by: agrima2010
Co-authored-by: kjelinjonas

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [ X] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Co-authored-by: agrima2010
Co-authored-by: kjelinjonas
@nkongenelly nkongenelly self-assigned this Nov 24, 2025
@nkongenelly nkongenelly reopened this Nov 24, 2025
@FranBonath FranBonath added this to the 1.0.0 milestone Nov 24, 2025
@FranBonath FranBonath moved this to In Progress in seqinspector project board Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Add relative sample size input in subsampling

2 participants