-
Notifications
You must be signed in to change notification settings - Fork 116
docs: Revamp NGINX technical specs summary table #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! @y82's call as the primary technical writer for this content.
I have hereby read the F5 CLA and agree to its terms |
recheck |
Hi @ChisomUma , I see you've signed the CLA as @ChisomUma . However, I think the bot is asking you to sign from the @UmaChisom account. Can you sign in as @UmaChisom and try again, please? ![]() |
I have hereby read the F5 CLA and agree to its terms |
recheck |
Oh yes, it worked now. Thank you! |
Co-authored-by: yar <[email protected]>
Co-authored-by: yar <[email protected]>
Co-authored-by: yar <[email protected]>
Co-authored-by: yar <[email protected]>
…Uma/ngixdocsopensourcecontribution into revamp-spec-summary-table
Hi @y82 I have responded to requested changes |
Hi @y82, any update on this PR? FYI- I keep getting automated deployment messages from the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified conformance to (all but one) suggested change, and have implemented that change.
Thank you @ChisomUma for your contribution! Let us know if you're interested in more :)
Hi @mjang thank you so much! And yes I am happy to be a regular contributor so I look forward to more work! |
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩