Skip to content

Conversation

kuthiala
Copy link
Contributor

@kuthiala kuthiala commented May 5, 2025

Proposed changes

Got feedback to have the terraform code in collapsible sections and improve the diagram to show the connections between the secondary deployment and the upstreams better. Also fixed a spelling error.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@kuthiala kuthiala requested review from a team as code owners May 5, 2025 20:35
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure labels May 5, 2025
Copy link

github-actions bot commented May 5, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/526/

Copy link

@amudukutore amudukutore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The diagram changes look good to me.
  • I like putting the code blocks into expandable sections.

Looks like some of the steps are missing now due to the expandable sections. Okay to merge once that is fixed.

@kuthiala kuthiala force-pushed the kuthiala-dev branch 4 times, most recently from fe6f9b0 to 95923a0 Compare May 5, 2025 21:58
@kuthiala kuthiala changed the title draft: add some formatting and a better diagram for NGINXaaS DR. feat: add some formatting and a better diagram for NGINXaaS DR. May 5, 2025
@JTorreG JTorreG merged commit 52f681e into main May 6, 2025
9 checks passed
@JTorreG JTorreG deleted the kuthiala-dev branch May 6, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants