Skip to content

Conversation

@y82
Copy link
Contributor

@y82 y82 commented May 29, 2025

This PR is not content-related and introduces some "technical" changes for the NGINX Plus Releases page:

  • Links converted from https://docs.nginx.com to ref
  • Updated date timestamp acc. to MS style guide
  • The "span" tag replaced with and Id
  • Table sizes and right border fixed
  • Misc small fixes

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@y82 y82 requested a review from a team as a code owner May 29, 2025 13:06
@y82 y82 self-assigned this May 29, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) labels May 29, 2025
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to see this: it's a large improvement for the consistency of our documentation, and the kind of work we have to chip at piece by piece.

@y82 y82 merged commit 9236fd8 into nginx:main Jun 3, 2025
7 checks passed
@y82 y82 deleted the rn_html branch June 3, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants