Skip to content

fix: include metrics in the helper template agent config #8404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −5
Open

fix: include metrics in the helper template agent config #8404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7869771
fix: include metrics in the helper template agent config
dareste Oct 10, 2025
7795514
Merge branch 'main' into areste-agent-metrics-config
dareste Oct 10, 2025
01403cb
chore: fix test snapshots
dareste Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nginx-ingress/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ tls:
features:
- registration
- nginx-counting
- metrics-sender
- metrics
- dataplane-status
extensions:
- nginx-app-protect
Expand Down
8 changes: 4 additions & 4 deletions charts/tests/__snapshots__/helmunit_test.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,7 @@ data:
features:
- registration
- nginx-counting
- metrics-sender
- metrics
- dataplane-status
extensions:
- nginx-app-protect
Expand Down Expand Up @@ -1323,7 +1323,7 @@ spec:
labels:
app.kubernetes.io/name: nginx-ingress
app.kubernetes.io/instance: app-protect-waf-agentv2
agent-configuration-revision-hash: "58428611"
agent-configuration-revision-hash: "df256a4f"
annotations:
prometheus.io/scrape: "true"
prometheus.io/port: "9113"
Expand Down Expand Up @@ -2055,7 +2055,7 @@ data:
features:
- registration
- nginx-counting
- metrics-sender
- metrics
- dataplane-status
extensions:
- nginx-app-protect
Expand Down Expand Up @@ -2376,7 +2376,7 @@ spec:
labels:
app.kubernetes.io/name: nginx-ingress
app.kubernetes.io/instance: app-protect-wafv5-agentv2
agent-configuration-revision-hash: "a8989f3a"
agent-configuration-revision-hash: "7f0862bf"
annotations:
prometheus.io/scrape: "true"
prometheus.io/port: "9113"
Expand Down
Loading