Replace hardcoded keys by javorszky · Pull Request #8536 · nginx/kubernetes-ingress

javorszky · 2025-11-14T12:25:07Z

Proposed changes

Having hardcoded kubernetes secrets is Bad™, even though they are only used as examples and in tests, and all of them are self-signed, we were still getting reports that hardcoded secrets were found.

This PR deletes the existing secrets, and replaces with a script that generates them as needed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copilot

Pull Request Overview

This PR removes hardcoded Kubernetes TLS secrets from the repository and replaces them with a script-based generation approach to address security scanning reports. While these secrets were only used for testing and examples with self-signed certificates, this change eliminates the security concern of committed secrets.

Key Changes:

Removed all hardcoded TLS secret YAML files containing base64-encoded certificates and keys
Added a Go-based certificate generation tool (hack/tls-cert-gen/) that creates secrets on-demand
Updated build process to generate certificates as needed via make certs command

Reviewed Changes

Copilot reviewed 79 out of 80 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`tests/data/*/tls-secret.yaml` (multiple)	Deleted symbolic links to common secret files
`examples/common-secrets/*.yaml` (multiple)	Removed hardcoded TLS secret YAML files with embedded certificates
`hack/tls-cert-gen/tls-cert-gen.go`	New certificate generation tool using Go crypto libraries
`hack/tls-cert-gen/certs.go`	Configuration defining all certificates to generate with domains and symlink targets
`hack/tls-cert-gen/makefile`	Build automation for certificate generation
`tests/.gitignore`	Added generated secret files to prevent accidental commits
`Makefile`	Added `certs` target for convenience
`.github/workflows/setup-smoke.yml`	Integrated certificate generation into CI workflow
`hack/cert-links/`	Added utility tool for analyzing certificate symlink structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hack/tls-cert-gen/makefile

hack/cert-links/main.go

codecov · 2025-11-14T13:56:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.94%. Comparing base (c15ff6d) to head (d2942d2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8536      +/-   ##
==========================================
- Coverage   53.95%   53.94%   -0.02%     
==========================================
  Files          91       91              
  Lines       18692    18692              
==========================================
- Hits        10086    10084       -2     
- Misses       8075     8077       +2     
  Partials      531      531

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-11-14T14:12:28Z

Package Report

Details

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx, 1.29.4-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-module-njs, 1.29.4+0.9.4-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-module-otel, 1.29.4+0.1.2-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 3.6.2~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx, 1.29.4-1~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-module-njs, 1.29.4+0.9.4-1~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-module-otel, 1.29.4+0.1.2-1~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 3.6.2~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus, 36-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-njs, 36+0.9.4-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 3.6.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus, 36-2~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-njs, 36+0.9.4-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-otel, 36+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-fips-check, 36+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 3.6.2~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus, 36-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-njs, 36+0.9.4-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-appprotect, 36+5.575.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect, 36+5.575.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-attack-signatures, 2026.01.14-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-threat-campaigns, 2026.01.21-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 2.45.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus, 36-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-njs, 36+0.9.4-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-appprotect, 36+5.575.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-module-plus, 36+5.575.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-plugin, 6.25.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 2.45.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus, 36-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-njs, 36+0.9.4-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-appprotectdos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-dos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus, 36-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-njs, 36+0.9.4-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-appprotect, 36+5.575.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect, 36+5.575.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-attack-signatures, 2026.01.14-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-threat-campaigns, 2026.01.21-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-plus-module-appprotectdos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, app-protect-dos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365, nginx-agent, 2.45.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx, 1.29.4-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-module-njs, 1.29.4.0.9.4-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-module-otel, 1.29.4.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-agent, 3.6.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx, 1.29.4-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-module-njs, 1.29.4.0.9.4-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-module-otel, 1.29.4.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-agent, 3.6.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus, 36-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus-module-njs, 36.0.9.4-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-agent, 3.6.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus, 36-r2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus-module-njs, 36.0.9.4-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus-module-otel, 36.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-plus-module-fips-check, 36.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine, nginx-agent, 3.6.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus, 36-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-njs, 36.0.9.4-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-agent, 3.6.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus, 36-r2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-njs, 36.0.9.4-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-agent, 3.6.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus, 36-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-njs, 36.0.9.4-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-agent, 2.45.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-appprotect, 36.5.575.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, app-protect, 36.5.575.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, app-protect-attack-signatures, 2026.01.14-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, app-protect-threat-campaigns, 2026.01.21-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus, 36-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-njs, 36.0.9.4-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-agent, 2.45.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, nginx-plus-module-appprotect, 36.5.575.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, app-protect-module-plus, 36.5.575.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-alpine-fips, app-protect-plugin, 6.25.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx, 1.29.4-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-module-njs, 1.29.4+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-module-otel, 1.29.4+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 3.6.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx, 1.29.4-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-module-njs, 1.29.4+0.9.5-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-module-otel, 1.29.4+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 3.6.2-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus, 36-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-njs, 36+0.9.4-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 3.6.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus, 36-2.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-njs, 36+0.9.4-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 3.6.2-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus, 36-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-njs, 36+0.9.4-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 2.45.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-appprotect, 36+5.575.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect, 36+5.575.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-attack-signatures, 2026.01.14-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-threat-campaigns, 2026.01.21-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus, 36-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-njs, 36+0.9.4-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 2.45.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-appprotect, 36+5.575.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-module-plus, 36+5.575.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-plugin, 6.25.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus, 36-2.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-njs, 36+0.9.4-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-otel, 36+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-fips-check, 36+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-agent, 2.45.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-appprotect, 36+5.575.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, app-protect, 36+5.575.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, app-protect-attack-signatures, 2026.01.14-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, app-protect-threat-campaigns, 2026.01.21-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus, 36-2.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-njs, 36+0.9.4-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-otel, 36+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-fips-check, 36+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-agent, 2.45.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, nginx-plus-module-appprotect, 36+5.575.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, app-protect-module-plus, 36+5.575.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi8, app-protect-plugin, 6.25.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus, 36-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-njs, 36+0.9.4-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-appprotectdos, 36+4.8.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-dos, 36+4.8.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus, 36-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-njs, 36+0.9.4-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-appprotect, 36+5.575.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-plus-module-appprotectdos, 36+4.8.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, nginx-agent, 2.45.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect, 36+5.575.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-attack-signatures, 2026.01.14-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-threat-campaigns, 2026.01.21-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-4a2e77c42caaa9bafae31165eb7b7365-ubi, app-protect-dos, 36+4.8.3-1.el9.ngx, x86_64

Makefile

Copilot

Pull request overview

Copilot reviewed 232 out of 251 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/suite/test_ingress_mtls.py

Makefile

examples/ingress-resources/complete-example/README.md

examples/ingress-resources/basic-auth/README.md

examples/ingress-resources/rewrite-target/README.md

examples/ingress-resources/security-monitoring/README.md

examples/custom-resources/basic-auth/README.md

Otherwise the linter complains that go:embed is trying to reach a file that does not exist.

Copilot AI review requested due to automatic review settings November 14, 2025 12:25

javorszky requested a review from a team as a code owner November 14, 2025 12:25

github-actions bot added go Pull requests that update Go code python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Nov 14, 2025

Copilot AI reviewed Nov 14, 2025

View reviewed changes

hack/tls-cert-gen/makefile Outdated Show resolved Hide resolved

hack/cert-links/main.go Outdated Show resolved Hide resolved

javorszky force-pushed the chore/np-136-replace-hardcoded-keys branch from 4527443 to 80611bb Compare November 14, 2025 13:51

javorszky force-pushed the chore/np-136-replace-hardcoded-keys branch 2 times, most recently from 25c0c15 to 2d1a3ce Compare November 18, 2025 15:27

javorszky added 18 commits November 19, 2025 13:19

Add tls gen script POC

e65aa40

More refinement to the tls gen script

a946d07

Replace NBSP with actual spaces in test makefile

43a0980

Update the tls cert generation script

910c048

Add cert link finder script

6a7d8d9

Write the files and symlinks

758cde3

Add inline comments

f1eaf33

More inline comments and code organisation

a638544

Fix symbolic link logic

d3f47a0

Refine tls cert gen script

9691313

Remove secrets from repository

1d18d69

Add makefile target to gen certs

e4ec215

Create default secret

42d1f36

Default TLS should be valid

6c0c05f

Add make certs to the smoke test setup step

06eb405

Generate the actual TLS files into a new dir

ce43097

Add examples gitignore file

3b901d3

Add generated symlink files to gitignores

5400b66

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

ec2041e

vepatel reviewed Jan 7, 2026

View reviewed changes

Makefile Outdated Show resolved Hide resolved

javorszky added 3 commits January 7, 2026 10:18

Renovate version go builder image

063a8cb

Add make secrets to tests/readme

fcb0923

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

16e7895

danielnginx requested a review from Copilot January 8, 2026 11:21

Copilot AI reviewed Jan 8, 2026

View reviewed changes

tests/suite/test_ingress_mtls.py Show resolved Hide resolved

tests/suite/test_ingress_mtls.py Outdated Show resolved Hide resolved

Remove debug print

3236cab

AlexFenlon reviewed Jan 12, 2026

View reviewed changes

javorszky added 9 commits January 12, 2026 11:40

Change capitalisation of makefile

5ca01a2

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

68e598b

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

39c5ba4

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

445efcc

Generate secrets for internal/k8s/secrets test

2663b3f

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

fbeed80

Remove debug logging

5ec20aa

Run make secrets before linting

bedae59

Otherwise the linter complains that go:embed is trying to reach a file that does not exist.

Also generate secrets for unit tests

e0b4b7c

AlexFenlon previously approved these changes Jan 16, 2026

View reviewed changes

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

d9caab0

javorszky dismissed AlexFenlon’s stale review via d9caab0 January 22, 2026 09:47

AlexFenlon approved these changes Jan 22, 2026

View reviewed changes

javorszky enabled auto-merge (squash) January 23, 2026 11:14

javorszky added 2 commits January 23, 2026 11:14

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

83d7c68

Merge branch 'main' into chore/np-136-replace-hardcoded-keys

d2942d2

haywoodsh approved these changes Jan 23, 2026

View reviewed changes

sean-breen approved these changes Jan 23, 2026

View reviewed changes

javorszky merged commit 8b6411f into main Jan 23, 2026
94 checks passed

javorszky deleted the chore/np-136-replace-hardcoded-keys branch January 23, 2026 11:54

AlexFenlon mentioned this pull request Jan 23, 2026

Update example Secret name mismatch in hack/secrets.json #8957

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace hardcoded keys#8536

Replace hardcoded keys#8536
javorszky merged 161 commits intomainfrom
chore/np-136-replace-hardcoded-keys

javorszky commented Nov 14, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

javorszky commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

javorszky commented Nov 14, 2025 •

edited

Loading

codecov bot commented Nov 14, 2025 •

edited

Loading

github-actions bot commented Nov 14, 2025 •

edited

Loading