-
Notifications
You must be signed in to change notification settings - Fork 2k
Replace hardcoded keys #8536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Replace hardcoded keys #8536
Changes from all commits
Commits
Show all changes
161 commits
Select commit
Hold shift + click to select a range
e65aa40
Add tls gen script POC
javorszky a946d07
More refinement to the tls gen script
javorszky 43a0980
Replace NBSP with actual spaces in test makefile
javorszky 910c048
Update the tls cert generation script
javorszky 6a7d8d9
Add cert link finder script
javorszky 758cde3
Write the files and symlinks
javorszky f1eaf33
Add inline comments
javorszky a638544
More inline comments and code organisation
javorszky d3f47a0
Fix symbolic link logic
javorszky 9691313
Refine tls cert gen script
javorszky 1d18d69
Remove secrets from repository
javorszky e4ec215
Add makefile target to gen certs
javorszky 42d1f36
Create default secret
javorszky 6c0c05f
Default TLS should be valid
javorszky 06eb405
Add make certs to the smoke test setup step
javorszky ce43097
Generate the actual TLS files into a new dir
javorszky 3b901d3
Add examples gitignore file
javorszky 5400b66
Add generated symlink files to gitignores
javorszky 532f493
Removing helper cert-links
javorszky f94956b
Move secret into generated list
javorszky 98cb600
Restore directories that was removed because empty
javorszky 6068ccb
Remove and ignore generated secret
javorszky a4a99ed
Clean up makefiles
javorszky 1e983be
Remove unneeded commented out code
javorszky 916ab7f
Use os.Lstat instead of os.Stat on symlinks
javorszky 82dc266
Use docker in case go is not available
javorszky f3dbb1d
Add logging to tls cert gen script
javorszky 6afe065
Rejig gitignore to account for moved folder
javorszky 444bfb1
Use the actual tls certs from the correct directory
javorszky e7ece67
Fix certs for test default server pytest
javorszky c784a81
Add explanations to certs and move a struct
javorszky c37cb1b
Remove duplicate symlinks
javorszky b907278
Create wildcard es tls cert
javorszky 64a5a57
Egress mtls test fix - WIP
javorszky 07c7366
Add cert for ap-waf-grpc test
javorszky ad4dc44
Update secrets for wildcard tls tests
javorszky 7824662
Make sure we don't overwrite an existing secret
javorszky ecde711
Also check for duplicate symlinks
javorszky a5e9010
Create cert for transport server backup service
javorszky eb805e1
Use a different cert for test_prometheus_metrics
javorszky 2e2b64e
Use a different cert for service insight
javorszky d92f8b3
Fix certs for test transport srv tcp loadbalanced
javorszky b41327a
Remove secret from being tracked
javorszky 2b5b89f
Create secret for test virt srv insight
javorszky e2d508d
Fix certs used by tls load balanced
javorszky e3817d8
Factor out writing the files from the tls gen
javorszky 4bf253b
egress mtls certificates almost done
javorszky 7b50044
Tls generation code done maybe
javorszky ff407c2
remove duplication from test Makefile
pdabelf5 15d0608
Small test adjustments
javorszky 175be42
Merge branch 'chore/np-136-replace-hardcoded-keys' of github.com:ngin…
pdabelf5 222f7bc
Add certs-clean target to Makefile and implement clean functionality …
pdabelf5 c89071f
extract certificate based secrets from test cases
pdabelf5 382e8ad
Generate server certs for egress-mtls
pdabelf5 9a64043
Tidy up
pdabelf5 394b56a
Remove unused secret files
pdabelf5 d72f6b0
Add invalid virtual-server-tls secret
pdabelf5 67cde66
Cleanup common secrets
pdabelf5 ddbe28a
Migrate TS secrets
pdabelf5 2f30532
Allow custom namespace for secrets
pdabelf5 8b7f681
Fixup HSTS TLS secrets
pdabelf5 4a25418
refactor to json file & add htpasswd
pdabelf5 053bb91
Updates to cert-manager test
pdabelf5 7048040
Update htpasswd examples
pdabelf5 969a3cb
Add TLS to cert manager backend checks
pdabelf5 87b43aa
Add htpasswd tests
pdabelf5 4b3c295
Add auth basic secrets tests
pdabelf5 fb7eebf
Add jwks generation and example
pdabelf5 eedd5f2
jwks test data
pdabelf5 4e10792
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
pdabelf5 deff43c
Create the gitignore script
javorszky 4cc926b
Generate gitignore section
javorszky 8d97bc3
Add a newline at the end of the gitignore file
javorszky 3e04763
Update golang.org/x/crypto to 0.45.0
javorszky a0ea39e
Add more ignored files
javorszky af9d899
Fix the template data to marshal issuer and subject
javorszky 47b0dd2
Marshal EC private key
javorszky 2eaefca
keycloak updates
pdabelf5 30bcc0d
Merge branch 'chore/np-136-replace-hardcoded-keys' of github.com:ngin…
pdabelf5 30182cf
Allow MTLS to not have a client
pdabelf5 d0f3ca4
keycloak tests
pdabelf5 0528a10
add basic jwt functionality
pdabelf5 397ad84
update jwt functionality
pdabelf5 8e8be7a
Update jwt tokens
pdabelf5 2a4b4a9
Update certmanager version in example
pdabelf5 ea141be
Update self-signed certs to be full CA's
pdabelf5 0bc59a4
change lint style
pdabelf5 9384446
Clean up certmanager leases after tests
pdabelf5 33e9c94
Update cert manager to 1.19.2
pdabelf5 b39a849
Correct github security code smells
pdabelf5 9e521f5
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
pdabelf5 c82acdd
Update secret details for failing tests
pdabelf5 b1d96f1
Update app protect grpc cert details
pdabelf5 ada4e3a
Correct path for TestVirtualServerUpstreamTls secret
pdabelf5 95e324d
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
pdabelf5 7bced1f
correct path to secret
pdabelf5 cf9d6db
Merge branch 'chore/np-136-replace-hardcoded-keys' of github.com:ngin…
pdabelf5 8a51703
add delay to mgmt configmap reload check
pdabelf5 d499e33
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
pdabelf5 2af5122
finishing touches
pdabelf5 ef25c1e
Merge branch 'chore/np-136-replace-hardcoded-keys' of github.com:ngin…
pdabelf5 ae0d7fe
change mgmt secret name
pdabelf5 0ce8148
Tidy up noisy neighbour MGMT configmap test
pdabelf5 6cc027f
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
pdabelf5 cb53dd6
change name of appprotect secret
pdabelf5 f551ade
rename certs make target to be more generic
pdabelf5 e20bd21
Update CI to use renamed make target
pdabelf5 854c694
Only out when debug is enabled
pdabelf5 dd83219
Clean up CRL files correctly
pdabelf5 11fbb4c
Add run make secret to readmes
javorszky 07ffb8e
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky add352e
Consolidate removeFiles for most secret types
javorszky 65cc2c7
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 99f3a48
Remove secrets to see if tests fail
javorszky b531669
Add ingress-mtls/secret as a kept empty directory
javorszky 6709337
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky e8c985a
Add api key generation
javorszky 5a392c4
Delete the last secret file and add gitkeep
javorszky f637e6b
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 8c45685
Rename folder and variables
javorszky c642d81
Fix filenames in generated files
javorszky 9a55881
Add api key secret files to gitignore
javorszky 2c2869b
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 9157d04
Use the correct data for the apikeys yaml
javorszky 3a7dd15
Ingress mtls secrets generation part 1
javorszky c6cc470
Generate correct valid client certs
javorszky ed2d0d0
Add generation of invalid certs
javorszky 8860f06
Add generating the revoked and not revoked certs
javorszky 6cd7385
Rework ingress-mtls secret data structure
javorszky 8b09737
Add in filenames and cleanpointer
javorszky b4cc79a
Rework ingress mtls generation
javorszky 0963ab9
Tweak gitignore gen and add ingress-mtls
javorszky 8e1fdfe
Removal of secret files
javorszky 99de45a
Remove unnecessary debug print
javorszky 5fbef75
Dedupe ingress-mtls ca generation
javorszky 9597673
Do not pass projectRoot around
javorszky 9c9731c
Add back an ingress-mtls symlink
javorszky 74c945e
Regenerate gitignore file
javorszky dff0ac4
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky f68201d
Add gitkeep to now empty directories
javorszky 53da83b
Fix valid client cert in ingress-mtls test
javorszky 81764d3
Remove an unnecessary test line
javorszky fd073b8
Add generation of certs to mgmg-configmap
javorszky 8c572c5
Add gitignore gen for mgmt configmap test
javorszky ec2041e
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 063a8cb
Renovate version go builder image
javorszky fcb0923
Add make secrets to tests/readme
javorszky 16e7895
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 3236cab
Remove debug print
javorszky 5ca01a2
Change capitalisation of makefile
javorszky 68e598b
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 39c5ba4
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 445efcc
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 2663b3f
Generate secrets for internal/k8s/secrets test
javorszky fbeed80
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 5ec20aa
Remove debug logging
javorszky bedae59
Run make secrets before linting
javorszky e0b4b7c
Also generate secrets for unit tests
javorszky d9caab0
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky 83d7c68
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky d2942d2
Merge branch 'main' into chore/np-136-replace-hardcoded-keys
javorszky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| common-secrets/*.yaml | ||
| custom-resources/api-key/cafe-secret.yaml | ||
| custom-resources/backup-directive/transport-server/app-tls-secret.yaml | ||
| custom-resources/backup-directive/virtual-server/cafe-secret.yaml | ||
| custom-resources/basic-auth/cafe-passwd.yaml | ||
| custom-resources/basic-auth/cafe-secret.yaml | ||
| custom-resources/basic-configuration/cafe-secret.yaml | ||
| custom-resources/cache-policy/cafe-secret.yaml | ||
| custom-resources/cross-namespace-configuration/cafe-secret.yaml | ||
| custom-resources/custom-ip-listeners/virtualserver/cafe-secret.yaml | ||
| custom-resources/custom-listeners/cafe-secret.yaml | ||
| custom-resources/egress-mtls/egress-mtls-secret.yaml | ||
| custom-resources/egress-mtls/egress-trusted-ca-secret.yaml | ||
| custom-resources/egress-mtls/secure-app-tls-secret.yaml | ||
| custom-resources/external-dns/cafe-secret.yaml | ||
| custom-resources/externalname-services/transport-server/app-tls-secret.yaml | ||
| custom-resources/foreign-namespace-upstreams/cafe-secret.yaml | ||
| custom-resources/grpc-upstreams/greeter-secret.yaml | ||
| custom-resources/ingress-mtls/tls-secret.yaml | ||
| custom-resources/jwks/tls-secret.yaml | ||
| custom-resources/jwt/jwk-secret.yaml | ||
| custom-resources/oidc-fclo/tls-secret.yaml | ||
| custom-resources/oidc/tls-secret.yaml | ||
| custom-resources/rate-limit-tiered-jwt-claim/cafe-secret.yaml | ||
| custom-resources/service-insight/service-insight-secret.yaml | ||
| custom-resources/tls-passthrough/app-tls-secret.yaml | ||
| custom-resources/transport-server-sni/cafe-secret.yaml | ||
| custom-resources/transport-server-sni/mongo-secret.yaml | ||
| ingress-resources/app-protect-dos/webapp-secret.yaml | ||
| ingress-resources/app-protect-waf/cafe-secret.yaml | ||
| ingress-resources/basic-auth/cafe-passwd.yaml | ||
| ingress-resources/basic-auth/cafe-secret.yaml | ||
| ingress-resources/complete-example/cafe-secret.yaml | ||
| ingress-resources/mergeable-ingress-types/cafe-secret.yaml | ||
| ingress-resources/proxy-set-headers/mergeable-ingress/cafe-secret.yaml | ||
| ingress-resources/proxy-set-headers/standard-ingress/cafe-secret.yaml | ||
| ingress-resources/rate-limit/cafe-secret.yaml | ||
| ingress-resources/security-monitoring/cafe-secret.yaml | ||
| shared-examples/default-server-secret/default-server-secret.yaml |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.