-
Couldn't load subscription status.
- Fork 141
Implement WAFPolicy controller #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3a3e51 to
89122cd
Compare
89122cd to
469bfd8
Compare
469bfd8 to
77a793f
Compare
ddeaa8e to
499cfed
Compare
499cfed to
752013c
Compare
ad59974 to
047418f
Compare
047418f to
28bcbe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small things, but overall looks pretty good!
internal/controller/nginx/config/policies/waf/generator_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
As a user of NGF I want my WafPolicy configuration applied to NGINX for the Gateway or Route scope So that I can enable WAF protection on my traffic Solution: Implement the WAFPolicy controller.
Proposed changes
Problem:
As a user of NGF
I want my WafPolicy configuration applied to NGINX for the Gateway or Route scope
So that I can enable WAF protection on my traffic
Solution: Implement the WAFPolicy controller.
Testing: Over 90% unit test coverage, and manual testing in a GKE cluster
Closes: #3454
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.