Skip to content

Conversation

@ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Jun 21, 2025

Proposed changes

Problem:
As a user of NGF
I want my WafPolicy configuration applied to NGINX for the Gateway or Route scope
So that I can enable WAF protection on my traffic

Solution: Implement the WAFPolicy controller.

Testing: Over 90% unit test coverage, and manual testing in a GKE cluster

Closes: #3454

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 force-pushed the feat/wafpolicy-ctlr branch from 469bfd8 to 77a793f Compare June 25, 2025 08:06
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Jun 25, 2025
@ciarams87 ciarams87 force-pushed the feat/wafpolicy-ctlr branch from ddeaa8e to 499cfed Compare June 25, 2025 17:04
@ciarams87 ciarams87 force-pushed the feat/wafpolicy-ctlr branch from 499cfed to 752013c Compare July 3, 2025 12:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 3, 2025
@ciarams87 ciarams87 force-pushed the feat/wafpolicy-ctlr branch 3 times, most recently from ad59974 to 047418f Compare July 3, 2025 19:02
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 3, 2025
@ciarams87 ciarams87 marked this pull request as ready for review July 3, 2025 19:03
@ciarams87 ciarams87 marked this pull request as draft July 3, 2025 19:07
@ciarams87 ciarams87 force-pushed the feat/wafpolicy-ctlr branch from 047418f to 28bcbe2 Compare July 3, 2025 21:42
@ciarams87 ciarams87 marked this pull request as ready for review July 3, 2025 22:01
@ciarams87 ciarams87 requested a review from a team July 3, 2025 22:01
Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things, but overall looks pretty good!

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ciarams87 ciarams87 merged commit f9a811c into feat/nap-waf Jul 8, 2025
37 checks passed
@ciarams87 ciarams87 deleted the feat/wafpolicy-ctlr branch July 8, 2025 21:35
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 8, 2025
ciarams87 added a commit that referenced this pull request Jul 9, 2025
As a user of NGF
I want my WafPolicy configuration applied to NGINX for the Gateway or Route scope
So that I can enable WAF protection on my traffic

Solution: Implement the WAFPolicy controller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement WafPolicy controller & generate the correct NGINX configuration

5 participants