Skip to content

Fix NFR tests #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025
Merged

Fix NFR tests #3722

merged 4 commits into from
Aug 12, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Aug 12, 2025

NFR tests were having some issues regarding applying the NginxProxy CRD and timing out when deleting the test namespace while cleaning up resources. Fixed the CRD issues by applying with additional flag and increased deletion namespace timeout.

@bjee19 bjee19 requested a review from a team as a code owner August 12, 2025 19:43
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.91%. Comparing base (1354b1d) to head (11fbc0d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3722      +/-   ##
==========================================
- Coverage   86.91%   86.91%   -0.01%     
==========================================
  Files         128      128              
  Lines       15962    15962              
  Branches       62       62              
==========================================
- Hits        13874    13873       -1     
  Misses       1921     1921              
- Partials      167      168       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 merged commit 2a82c8e into main Aug 12, 2025
44 checks passed
@bjee19 bjee19 deleted the chore/use-force-conflicts branch August 12, 2025 20:15
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 12, 2025
bjee19 added a commit that referenced this pull request Aug 12, 2025
NFR tests were having some issues regarding applying the NginxProxy CRD and timing out when deleting the test namespace while cleaning up resources. Fixed the CRD issues by applying with additional flag and increased deletion namespace timeout.
bjee19 added a commit that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants