Skip to content

Cherry pick/worker conns #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Cherry pick/worker conns #3732

wants to merge 4 commits into from

Conversation

sarthyparty
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


bjee19 and others added 4 commits August 12, 2025 15:46
Cherry-pick: update NGINX Plus version to R35
Add nginx one console connection telemetry field (#3717)

Problem: We want to know how many clusters are connected to NGINX One console.

Solution: Reports product telemetry to report if cluster is connected to NGINX One console
@sarthyparty sarthyparty requested a review from a team as a code owner August 14, 2025 00:42
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Aug 14, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 14, 2025
@sjberman sjberman added bug Something isn't working and removed documentation Improvements or additions to documentation tests Pull requests that update tests labels Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.95%. Comparing base (00112a4) to head (89e085d).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/manager.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3732   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files         128      128           
  Lines       15962    15986   +24     
  Branches       62       62           
=======================================
+ Hits        13879    13901   +22     
- Misses       1917     1918    +1     
- Partials      166      167    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman deleted the cherry-pick/worker-conns branch August 14, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants