Skip to content

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Sep 15, 2025

Problem: The default NGINX Plus image wasn't being set properly.

Solution: Set the default if running Plus.

Closes #3920

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Set correct default NGINX Plus image when not specified by user.

Problem: The default NGINX Plus image wasn't being set properly.

Solution: Set the default if running Plus.
@sjberman sjberman requested a review from a team as a code owner September 15, 2025 16:38
@github-actions github-actions bot added the bug Something isn't working label Sep 15, 2025
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.80%. Comparing base (4e3dc46) to head (b2995e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3919      +/-   ##
==========================================
+ Coverage   86.78%   86.80%   +0.02%     
==========================================
  Files         128      128              
  Lines       16500    16503       +3     
  Branches       62       62              
==========================================
+ Hits        14319    14325       +6     
+ Misses       2001     1999       -2     
+ Partials      180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) September 15, 2025 17:34
@sjberman sjberman merged commit 635b3fc into main Sep 15, 2025
65 of 66 checks passed
@sjberman sjberman deleted the fix/nplus-default-image branch September 15, 2025 17:56
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

NGINX Plus default container image not set properly

3 participants