Skip to content

Set NGINX Plus default image #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Set NGINX Plus default image #3919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7f621d
Set NGINX Plus default image
sjberman Sep 15, 2025
b2995e0
Merge branch 'main' into fix/nplus-default-image
sjberman Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/controller/provisioner/objects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,9 @@ func (p *NginxProvisioner) buildNginxPodTemplateSpec(

func (p *NginxProvisioner) buildImage(nProxyCfg *graph.EffectiveNginxProxy) (string, corev1.PullPolicy) {
image := defaultNginxImagePath
if p.cfg.Plus {
image = defaultNginxPlusImagePath
}
tag := p.cfg.GatewayPodConfig.Version
pullPolicy := defaultImagePullPolicy

Expand Down
2 changes: 2 additions & 0 deletions internal/controller/provisioner/objects_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ func TestBuildNginxResourceObjects_Plus(t *testing.T) {
cfg: Config{
GatewayPodConfig: &config.GatewayPodConfig{
Namespace: ngfNamespace,
Version: "1.0.0",
},
Plus: true,
PlusUsageConfig: &config.UsageReportConfig{
Expand Down Expand Up @@ -611,6 +612,7 @@ func TestBuildNginxResourceObjects_Plus(t *testing.T) {
Name: "nginx-plus-usage-certs",
MountPath: "/etc/nginx/certs-bootstrap/",
}))
g.Expect(container.Image).To(Equal(fmt.Sprintf("%s:1.0.0", defaultNginxPlusImagePath)))
}

func TestBuildNginxResourceObjects_DockerSecrets(t *testing.T) {
Expand Down
Loading