WIP - Update AsyncGenerator to v0.11.0 to fix #1672 #1674
Conversation
…d regenerated the Async classes
hazzik
changed the title
|
Since you have added maca88/AsyncGenerator#96, I guess this should be considered WIP for now. |
fredericDelaporte
changed the title
| @@ -50,6 +50,8 @@ | |||
| <arg value="msbuild" /> | |||
| <arg value="/t:Restore" /> | |||
| <arg value="${root.dir}/src/NHibernate.sln" /> | |||
| <arg value="/p:Platform="Any CPU"" /> | |||
| <arg value="/p:Configuration="${build.config}""/> | |||
There was a problem hiding this comment.
because without them I get the following when trying to generate the async classes (menu option H. Generate async code)
solution-restore:
[exec] Starting 'dotnet (msbuild /t:Restore ./src/NHibernate.sln)' in 'C:\Git\nhibernate-core'
[exec] Microsoft (R) Build Engine version 15.6.82.30579 for .NET Core
[exec] Copyright (C) Microsoft Corporation. All rights reserved.
[exec]
[exec] C:\Git\nhibernate-core\src\NHibernate.sln.metaproj : error MSB4126: The specified solution configuration "Debug|AnyCPU" is invalid. Please specify a valid solution configuration using the Configuration and Platform properties (e.g. MSBuild.exe Solution.sln /p:Configuration=Debug /p:Platform="Any CPU") or leave those properties blank to use the default solution configuration. [C:\Git\nhibernate-core\src\NHibernate.sln]
BUILD FAILED
it was the easiest solution I could find.
There was a problem hiding this comment.
Check your environment variables. You likely have a configuration or platform one defined in the command line you use for generating async code. They must be unset to avoid having their values messing with MsBuild parameters.
There was a problem hiding this comment.
After a reboot it worked again without the specific platform and configuration switches. However given that these are explicitly specified for the build, is it not also worthwhile doing so for the solution-restore step? Would avoid similar unexpected issues in future.
There was a problem hiding this comment.
Granted. Still a bit unrelated to this PR and commit.
Code regenerated to add missing OperationCanceledException where required. Fixes nhibernate#1674
Code regenerated to add missing OperationCanceledException where required. Fixes nhibernate#1674
|
I think we need to keep something opened, because merging 5.1.x in master will currently only temporarily fix the trouble: the master AsyncGenerator is a 0.10 version which does not yet handle properly cancellation exceptions. When merging, I do not think we should downgrade the generator to 0.8.2.4, so the next AsyncGeneration would lose the proper exception handling. |
But the master is on 0.8.2.1, so this can be really closed. |
And regenerate the Async classes.
See #1672.