Add missing OperationCanceledException in async code where required #1684
Conversation
Code regenerated to add missing OperationCanceledException where required. Fixes nhibernate#1674
| [Test] | ||
| public async Task UpdateConflictDetectedByNHAsync() | ||
| public async Task UpdateConflictDetectedByNHAsync(CancellationToken cancellationToken = default(CancellationToken)) |
There was a problem hiding this comment.
Sorry, I overlooked this change. I've released version 0.8.2.3 which doesn't generate it.
There was a problem hiding this comment.
Thanks again @maca88, but these changes are still there with 0.8.2.3.
There was a problem hiding this comment.
I tried to regenerate the code twice before releasing and the change was never there. Then I remembered that this issue occurred randomly depending on the order of the methods being analyzed, which was discovered and fixed when #86 was done. I've ported the fix and released it in 0.8.2.4. Again, sorry for the confusion.
There was a problem hiding this comment.
No trouble, do not be sorry, it is already great you take the time to back-port things to old versions.
Of course, to be squashed
fredericDelaporte
changed the title
hazzik
changed the title
|
It is in fact the fix for #1672, both included in 5.1.2 milestone, so retagging for avoiding a dup in notes. |
|
Ok |
Fixes #1672