Use NHS Prototype kit package #688
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a dependency on a new `nhsuk-prototype-kit` package, where the code in `lib/` has been moved to.
These can now be done upstream
This is required upstream
This is done upstream
This remove the cookie store option
This is now done upstream
This will be done by the kit itself.
This can now be app-level code, as it's not part of the prototype kit itself
One less dependency. Copied from #613
This doesn't work as you get an error earlier.
This isn't really needed as the file should now be there by default.
This can now be configured in the package
Now done by the kit itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dependency on a new
nhsuk-prototype-kitpackage, where the code inlib/has been moved to.This then simplifies the
app.jsfile, and will make updates to the code a lot easier.As part of this change, this repo would then become versionless, in recognition of its role as a 'template repositroy', where the 'Use this template' button always creates a copy from the latest version in
main.The
nhsuk-prototype-kitpackage version numbering would start at8.0.0, picking up the numbering from this repo (currently on7.x).Resolves nhsuk/nhsuk-prototype-kit-package#63