Skip to content

Conversation

@mjohanse-emr
Copy link
Collaborator

What does this Pull Request accomplish?

  • Updates pyproject.toml using the poetry migrator tool to be compatible with poetry 2.1.4
  • Updates dependencies on ni-grpc-extensions and ni.measurementlink.discovery.v1.proto to fix mypy errors and use the SERVICE_PROGRAMMING_LANGUAGE constant from discovery.proto.annotations.

Why should this Pull Request be merged?

We are moving all python projects to Poetry 2.1.4

What testing has been done?

Unit tests, mypy, pyright, styleguide.

Michael Johansen added 2 commits September 8, 2025 15:20
Signed-off-by: Michael Johansen <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Test Results

   76 files  ±0     76 suites  ±0   1m 57s ⏱️ +3s
  187 tests ±0    185 ✅ ±0   2 💤 ±0  0 ❌ ±0 
1 850 runs  ±0  1 820 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit fd833c3. ± Comparison against base commit 296e81f.

♻️ This comment has been updated with latest results.

Michael Johansen added 3 commits September 8, 2025 15:35
@mjohanse-emr mjohanse-emr marked this pull request as ready for review September 9, 2025 14:57
Copy link
Collaborator

@jfriedri-ni jfriedri-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see these changes begin 🤩

Copy link
Collaborator

@jfriedri-ni jfriedri-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to wait for Mike's response about Sphinx version selection.

@mjohanse-emr mjohanse-emr merged commit 7aedc4f into main Sep 9, 2025
97 checks passed
@mjohanse-emr mjohanse-emr deleted the users/mjohanse/use_annotation_constant branch September 9, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants