-
Couldn't load subscription status.
- Fork 0
Add a converter for dt.timedelta. #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
Test Results 10 files ± 0 10 suites ±0 23s ⏱️ -8s Results for commit 29ab5ea. ± Comparison against base commit 5ade5a6. This pull request removes 26 and adds 29 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mikeprosserni
approved these changes
Aug 4, 2025
jfriedri-ni
approved these changes
Aug 4, 2025
Signed-off-by: Michael Johansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
datetime.timedeltaandduration_pb2.Duration.datetime.timedeltavalue to the "all types" example.timedeltaon the panel, so I think this is sufficient.Why should this Pull Request be merged?
Implements part of AB#3164818
What testing has been done?
Unit tests, mypy, pyright, styleguide.
I ran the "all types" example and this is what shows up for

dt_datetime: