Include estimated build time of subtree in the edge weight heuristic#2686
Open
PowellNGL wants to merge 1 commit intoninja-build:masterfrom
Open
Include estimated build time of subtree in the edge weight heuristic#2686PowellNGL wants to merge 1 commit intoninja-build:masterfrom
PowellNGL wants to merge 1 commit intoninja-build:masterfrom
Conversation
moritzx22
reviewed
Jan 31, 2026
| @@ -468,7 +468,9 @@ namespace { | |||
| // Heuristic for edge priority weighting. | |||
| // Phony edges are free (0 cost), all other edges are weighted equally. | |||
Contributor
There was a problem hiding this comment.
// ... all other edges are weighted equally.
This comment is outdated and could be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #2682, this change uses the estimated build time of a subtree (measured during the previous run) as the scheduler heuristic instead of just its depth. This can make rebuilds faster by starting the critical path as early as possible