Skip to content

Include estimated build time of subtree in the edge weight heuristic #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PowellNGL wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Include estimated build time of subtree in the edge weight heuristic #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/build.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,9 @@ namespace {
// Heuristic for edge priority weighting.
// Phony edges are free (0 cost), all other edges are weighted equally.
Copy link
Contributor

@moritzx22 moritzx22 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// ... all other edges are weighted equally.

This comment is outdated and could be updated.

int64_t EdgeWeightHeuristic(Edge *edge) {
return edge->is_phony() ? 0 : 1;
int64_t prev_elapsed_time_millis =
edge->prev_elapsed_time_millis < 0 ? 1 : edge->prev_elapsed_time_millis;
return edge->is_phony() ? 0 : prev_elapsed_time_millis;
}

} // namespace
Expand Down