FIX: Orient fieldmap before checking spline fit #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 57.77% 57.75% -0.02%
==========================================
Files 72 72
Lines 6809 6811 +2
Branches 828 829 +1
==========================================
Hits 3934 3934
- Misses 2666 2668 +2
Partials 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgxd
approved these changes
Jul 2, 2025
mgxd
added a commit
that referenced
this pull request
Jul 2, 2025
25.1.1 (July 2, 2025) A patch release in the 25.1.x series. Includes a fix to the fieldmap reference orientation to match the B-spline coefficients. Thanks to @joey-scanga for the contribution! - Bug Fixes * FIX: Orient fieldmap before checking spline fit (#475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #471 where the extracted spline grid (in RAS orientation) didn't align with the fieldmap in a different orientation fed into Nibabies. Making this change and rebuilding the Docker image on my own machine removed the error I saw in the issue