-
Notifications
You must be signed in to change notification settings - Fork 54
MAINT: Finalize upstreaming of ants interfaces to nipype #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
52831d2
to
b6721a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 64.65% 60.03% -4.62%
==========================================
Files 44 43 -1
Lines 5375 5170 -205
Branches 786 749 -37
==========================================
- Hits 3475 3104 -371
- Misses 1742 1931 +189
+ Partials 158 135 -23
Continue to review full report at Codecov.
|
With this perspective, this PR can be postponed until after the RC. |
043eb57
to
6d96b40
Compare
08f14af
to
dbb0bfa
Compare
dbb0bfa
to
05ed09a
Compare
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
05ed09a
to
c8161b9
Compare
After nipy/nipype#3210 the
niworkflows/interfaces/ants.py
can go in whole.@mgxd we need to cut an RC (talking about fMRIPrep) and exercise this particular change in a good range of datasets to make sure all use-cases are covered. Happy to talk about more targetted tests. This integration could be disastrous in the long term.