MAINT: Move fully to setuptools #764
Conversation
|
If we are inclined to move to versioneer, then we can drop the nisext usage altogether. |
effigies
force-pushed
the
maint/setuptools
branch
from
666b1b3 to
8471c35
Compare
effigies
force-pushed
the
maint/setuptools
branch
2 times, most recently
from
4ce67a3 to
e9110d7
Compare
effigies
force-pushed
the
maint/setuptools
branch
from
e9110d7 to
80b6174
Compare
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
- Coverage 89.99% 89.97% -0.02%
==========================================
Files 94 94
Lines 12015 11992 -23
Branches 2128 2128
==========================================
- Hits 10813 10790 -23
+ Misses 859 858 -1
- Partials 343 344 +1
Continue to review full report at Codecov.
|
effigies
force-pushed
the
maint/setuptools
branch
from
6eb1a50 to
2900c22
Compare
effigies
force-pushed
the
maint/setuptools
branch
from
2900c22 to
3221e53
Compare
|
This is all set. This sets a minimum setuptools requirement of 30.3.0, due to moving most of the metadata to I've pushed off versioneer mostly because of the |
| install_requires = | ||
| numpy >=1.8 | ||
| six >=1.3 | ||
| bz2file ; python_version < "3.0" |
There was a problem hiding this comment.
Do you by any chance remember from what setuptools version this extended setup.cfg is supported? I just fear possible troubles on older systems
There was a problem hiding this comment.
In general, will it be a problem for older systems to upgrade setuptools? That version had a python_requires='>=2.6,!=3.0.*,!=3.1.*,!=3.2.*' constraint, which is a superset of our own support level.
There was a problem hiding this comment.
@yarikoptic Sorry to bug you, but I just want to check whether that's sufficiently old, or you still think this could produce problems... I can revert to a pre-30.3-style setuptools config, if this is a serious concern.
|
Current debian stable stretch has 33. Oldstable Jessie only elderly 5 and we backported nibabel for it before http://neuro.debian.net/pkgs/python-nibabel.html but I think it is ok to stop carrying about it looking forward |
|
Okay. If somebody complains after 2.5 comes out, we can release a bugfix. Thanks for checking into this. |
Dug through nisext finally, and I agree with #717 (comment) that we can probably drop most of that from our setup.py. While I'm at it, I'm moving us to a
setup.cfg-based setup.No rush on this one. Would be nice to move by 2.5 or 3.0.
Closes #717.