-
Notifications
You must be signed in to change notification settings - Fork 265
MAINT: Manage versioning with versioneer #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
=========================================
- Coverage 90.11% 90.1% -0.01%
=========================================
Files 94 95 +1
Lines 11886 11879 -7
Branches 2119 2118 -1
=========================================
- Hits 10711 10704 -7
- Misses 831 834 +3
+ Partials 344 341 -3
Continue to review full report at Codecov.
|
1fe75c5
to
393e74c
Compare
One remaining question is whether to move from the custom version comparison code to It would be a new dependency, but fairly lightweight and pushes correctness concerns upstream. |
e162200
to
3c5a960
Compare
7a44899
to
3c5a960
Compare
eb64ef5
to
114a551
Compare
Made and tagged nibabel-specific hacks for including a fallback version for using with git-archive. This is no longer the canonical versioneer but should behave identically except in git archives made on non-release revisions.
114a551
to
30c536f
Compare
No major outcry, and we're testing |
This is a follow-up to #764. Now that we have a tag post-upstream/2.5.0.dev, Versioneer should be able to construct valid PEP-440-style version strings from any revision, and we can drop our custom githash handling code and nisext.
I don't think this should have negative impacts, but I'm going to leave this one open for a week or two in case anybody foresees problems with this move.