Skip to content

Conversation

effigies
Copy link
Member

We haven't been updating contributors properly. I think it will generally be easier to have people add themselves to CITATION.cff when they do contribute.

There isn't a distinction between creators and contributors, so that's one downside here.

Please confirm your ORCIDs, names and affiliations: @bpinsard @jbanusco @mvdoc @jmarabotto @feilong @Shotgunosine @shnizzedy @coryshain

@mvdoc
Copy link
Member

mvdoc commented May 31, 2025

LGTM. Thanks!

Copy link

codecov bot commented May 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.38%. Comparing base (4136681) to head (7ee94ba).
⚠️ Report is 107 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   95.15%   95.38%   +0.22%     
==========================================
  Files          28       28              
  Lines        2933     2948      +15     
==========================================
+ Hits         2791     2812      +21     
+ Misses        142      136       -6     
Flag Coverage Δ
unittests 95.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryshain
Copy link
Contributor

It's nice of you to include me in the citation! My info there is right. But I also modified exactly 2 lines of code so I don't think you need to credit me. I'll leave that up to you.

@feilong
Copy link
Contributor

feilong commented Jun 1, 2025

Thanks for putting this together @effigies ! It looks great to me.

@effigies effigies merged commit eecb287 into master Jun 2, 2025
15 checks passed
license: MIT
type: software
url: https://github.com/nipy/nitransforms/
version: 24.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this overriden by releases?

Copy link
Member Author

@effigies effigies Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets overridden by Zenodo, but we should probably make updating it part of the release process so it's up-to-date in git and source archives.

@effigies effigies deleted the citationcff branch September 5, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants