Skip to content

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Feb 17, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Fixes test_environments after syntax changes in #768

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@satra
Copy link
Contributor

satra commented Feb 25, 2025

@tclose - just a quick note that instead of building singularity you can install apptainer directly from binaries. example here: https://github.com/ReproNim/neurodocker/blob/eb4720e1e04f7347488d63fe05fcdafabaaac9bd/.github/workflows/pull-request.yml#L20

@tclose tclose marked this pull request as ready for review February 25, 2025 10:55
@tclose tclose merged commit 4b97ed6 into develop Feb 25, 2025
7 of 29 checks passed
@tclose
Copy link
Contributor Author

tclose commented Feb 25, 2025

@tclose - just a quick note that instead of building singularity you can install apptainer directly from binaries. example here: https://github.com/ReproNim/neurodocker/blob/eb4720e1e04f7347488d63fe05fcdafabaaac9bd/.github/workflows/pull-request.yml#L20

Thanks, should I include it in the main test build and drop the separate singularity one?

@satra
Copy link
Contributor

satra commented Feb 25, 2025

Thanks, should I include it in the main test build and drop the separate singularity one?

your call with the refactor as it depends on where singularity/apptainer gets used. it's a relatively quick install, so if it's helpful to bundle into a single test that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants