Skip to content

Conversation

tclose
Copy link
Contributor

@tclose tclose commented May 2, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

In custom compose plugins, there may not be a way to implicitly pull out help strings, in which case they will be None by default in ensure_field_objects, but this was not being checked.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (964793d) to head (af54f3d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   88.71%   88.74%   +0.02%     
==========================================
  Files          84       84              
  Lines       17891    17890       -1     
  Branches     1555     3483    +1928     
==========================================
+ Hits        15872    15876       +4     
+ Misses       1650     1643       -7     
- Partials      369      371       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose force-pushed the no-implicit-helps branch from c967ec8 to c279537 Compare May 6, 2025 00:10
@tclose tclose merged commit 058d793 into main May 12, 2025
30 checks passed
@tclose tclose deleted the no-implicit-helps branch May 13, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants