Skip to content

added guard against missing implicit helps in custom compose packages #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

added guard against missing implicit helps in custom compose packages #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b58227f
added guard against missing implicit helps in custom compose packages
tclose May 2, 2025
c279537
chore: removed unused import
tclose May 2, 2025
af54f3d
ensure that helps are empty string not none
tclose May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pydra/compose/base/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import types
from pathlib import Path
from copy import copy
import attrs.validators
from pydra.utils.typing import TypeParser, is_optional, is_fileset_or_union
import attrs
from .task import Task, Outputs
Expand Down
4 changes: 2 additions & 2 deletions pydra/compose/base/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def ensure_field_objects(
else:
arg.name = input_name
if not arg.help:
arg.help = input_helps.get(input_name, "")
arg.help = input_helps.get(input_name, "") if input_helps else ""
elif is_type(arg):
inputs[input_name] = arg_type(
type=arg,
Expand Down Expand Up @@ -101,7 +101,7 @@ def ensure_field_objects(
else:
out.name = output_name
if not out.help:
out.help = output_helps.get(output_name, "")
out.help = output_helps.get(output_name, "") if output_helps else ""
elif is_type(out):
outputs[output_name] = out_type(
type=out,
Expand Down
Loading