Skip to content

Conversation

satra
Copy link
Contributor

@satra satra commented Aug 13, 2025

Types of changes

Improve howto for environments

Summary

adds information on how to use and create environments

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (b0a9552) to head (f6d6548).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.01%     
==========================================
  Files          86       86              
  Lines       17988    17988              
  Branches     3509     3509              
==========================================
- Hits        15925    15924       -1     
+ Misses       1684     1683       -1     
- Partials      379      381       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satra satra requested a review from tclose August 13, 2025 16:56
Copy link
Contributor

@tclose tclose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@tclose tclose merged commit 94c1aa3 into main Aug 13, 2025
54 of 57 checks passed
@satra
Copy link
Contributor Author

satra commented Aug 13, 2025

@tclose - this unfortunately has all kinds of errors that should be fixed. i'll open another PR. and this makes me think that we need a better of model of code testing in the docs.

also i realize that there is no example in the tests of running a python function inside a container. all the current examples are shell commands.

@tclose
Copy link
Contributor

tclose commented Aug 14, 2025

sorry, I should have checked more closely

@tclose
Copy link
Contributor

tclose commented Aug 14, 2025

@satra
Copy link
Contributor Author

satra commented Aug 14, 2025

@tclose - if you have time to fix this up that would be great. if not, i'll have to punt this fix till friday.

@tclose tclose deleted the enh/env-doc branch August 15, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants