chore(wpt): warn for non-existent wpt path #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
reviewed
Sep 19, 2024
jazelly
force-pushed
the
better-error-unknown-wpt
branch
from
6ec7691 to
2cf9bc7
Compare
jazelly
changed the title
jazelly
force-pushed
the
better-error-unknown-wpt
branch
from
2cf9bc7 to
c2d09f4
Compare
aduh95
reviewed
Sep 19, 2024
jazelly
force-pushed
the
better-error-unknown-wpt
branch
from
ed9c215 to
64ca75e
Compare
aduh95
approved these changes
Sep 20, 2024
joyeecheung
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of
git node wpt anyUnknownPath, currently we get aTypeError: cannot read from undefined, which is not intuitive.