Skip to content

Conversation

@MattIPv4
Copy link
Member

Should stop the workflow racing itself as seen in #439 + #440

@MattIPv4 MattIPv4 requested a review from a team as a code owner May 21, 2025 15:44

concurrency:
group: update-redirect-links
cancel-in-progress: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should cancel in progress to start the most recent one, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I want whatever runs first to complete, so that you don't end up in a race where one has say created the branch but not the PR, and the second run then collides with the existing branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cancel-in-progress: false
# Allow existing runs to complete to avoid branch collisions
cancel-in-progress: false

Worth adding this to clarify?

@MattIPv4 MattIPv4 changed the title ci: restrict concurrency on update-links workflow actions: restrict concurrency on update-links workflow May 21, 2025
Copy link
Member

@flakey5 flakey5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MattIPv4 MattIPv4 merged commit 2cfba0e into main May 22, 2025
6 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/update-links-concurrency branch May 22, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants