Skip to content

actions: restrict concurrency on update-links workflow #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattIPv4 merged 1 commit into from
May 22, 2025
Merged

actions: restrict concurrency on update-links workflow #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/update-links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
schedule:
- cron: "0 0 * * *"

concurrency:
group: update-redirect-links
cancel-in-progress: false
Copy link
Member

@ovflowd ovflowd May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should cancel in progress to start the most recent one, no?

Copy link
Member Author

@MattIPv4 MattIPv4 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I want whatever runs first to complete, so that you don't end up in a race where one has say created the branch but not the PR, and the second run then collides with the existing branch.

Copy link
Member Author

@MattIPv4 MattIPv4 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cancel-in-progress: false
# Allow existing runs to complete to avoid branch collisions
cancel-in-progress: false

Worth adding this to clarify?


jobs:
update-redirect-links:
name: Update Redirect Links
Expand Down
Loading