feat(migrate-legacy-buffer-atob-btoa): introduce
#206
Conversation
| "author": "nekojanai (Jana)", | ||
| "license": "MIT", | ||
| "homepage": "https://github.com/nodejs/userland-migrations/blob/main/recipes/buffer-atob-btoa/README.md", | ||
| "dependencies": { |
There was a problem hiding this comment.
Maybe need to add jssg types as devdep to have typing on codemod context
There was a problem hiding this comment.
@nekojanai you have to add it for strictness
nekojanai
force-pushed
the
feat(`migrate-legacy-buffer-atob-btoa`)
branch
from
23a2fcf to
2c2fee2
Compare
nekojanai
force-pushed
the
feat(`migrate-legacy-buffer-atob-btoa`)
branch
from
2c2fee2 to
f6f823e
Compare
|
@AugustinMauroy Could you provide examples for dynamic and esm imports to test against? |
ESM importInput/before: import buffer from "node:buffer";
// do stuffDynamic importconst buffer = await import("node:buffer");
// do stuffDon't worry it's shouldn't complicated because we have serval utilities for that |
JakobJingleheimer
added
the
awaiting author
|
Should be gtm |
brunocroh
removed
the
awaiting author
| } | ||
| ]; | ||
|
|
||
| const statements = [...getNodeRequireCalls(root, 'buffer'), ...getNodeImportStatements(root, 'buffer')]; |
There was a problem hiding this comment.
| const statements = [...getNodeRequireCalls(root, 'buffer'), ...getNodeImportStatements(root, 'buffer')]; | |
| const statements = [ | |
| ...getNodeRequireCalls(root, 'buffer'), | |
| ...getNodeImportStatements(root, 'buffer') | |
| ]; |
|
|
||
| export default function transform(root: SgRoot<Js>): string | null { | ||
| const rootNode = root.root(); | ||
| const bindingStatementFnTuples: [string, SgNode<Js, Kinds<Js>>, (arg: string) => string][] = []; |
There was a problem hiding this comment.
| const bindingStatementFnTuples: [string, SgNode<Js, Kinds<Js>>, (arg: string) => string][] = []; | |
| const bindingStatementFnTuples: [string, SgNode<Js>, (arg: string) => string][] = []; |
this type can be simplified
| } | ||
| }); | ||
|
|
||
| const otherCalls = rootNode.findAll({ |
There was a problem hiding this comment.
if you remove that it's should work
There was a problem hiding this comment.
But do I not need to check for any other calls to an import before deleting it?
There was a problem hiding this comment.
Oh make sense maybe add comment on top of this query
| linesToRemove.push(statement.range()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
| if (!edits.lenght) return null | |
AugustinMauroy
added
the
awaiting author
closes #98